search

waldyrious / primerpedia

Simplified extracts of Wikipedia articles, showing just the basic information.
https://primerpedia.toolforge.org
Other
11 stars 7 forks source link

Update URL upon submitting a search query #22

Closed waldyrious closed 7 years ago

waldyrious commented 8 years ago

So that the URL can be shared. Background: #13.

waldyrious commented 7 years ago

21 implemented performing searches from a parameter passed in the URL, so the format should be something like https://waldyrious.github.io/primerpedia/?page=search%20terms (I think the parameter could be renamed from page= to search=, for clarity).

Unfortunately, that functionality doesn't seem to be working at the moment, so that needs to be fixed first. I wonder if this has anything to do with https://github.com/waldyrious/primerpedia/pull/26/commits/42cb953bb ? /cc @Jan-Ka, @joeinnes.

Jan-Ka commented 7 years ago

That is interesting. No, I don't think that is the culprit, it could be if it was a timing issue. Should be easy to fix - I will look into it if no one minds.

Edit: Hey @waldyrious,

the code currently checks for the search parameter instead of page. That's why your link (while http://waldyrious.net/primerpedia/?search=contractual%20terms does) does not work.

Checking the History revealed 5920f6a9a69e586cec10883e5f78817cf3bd1c13 - appears that you changed that while documenting the source file.

Can we close this issue?

I should have read the whole ticket beforehand. Sorry! However this is implemented by #34 / #7 .

waldyrious commented 7 years ago

the code currently checks for the search parameter instead of page. That's why your link (while http://waldyrious.net/primerpedia/?search=contractual%20terms does) does not work.

Checking the History revealed 5920f6a9a69e586cec10883e5f78817cf3bd1c13 - appears that you changed that while documenting the source file.

Ah, how silly of me! Thanks for catching that :)

And yeah, #34 fixes this one as well as #7. You're on a roll! :fire: