search

waldyrious / primerpedia

Simplified extracts of Wikipedia articles, showing just the basic information.
https://primerpedia.toolforge.org
Other
11 stars 7 forks source link

Ditch jQuery #26

Closed Jan-Ka closed 7 years ago

Jan-Ka commented 7 years ago

This will resolve #16 .

Commits of Interest / Discussion are:

The flowtype version is an adaptation from a Pull Request in the original Repository. I guess flowtype is no longer maintained.

Along the removal of jQuery are some fixes for issues that the original source had like some of the UI elements never getting hidden again or the script silently crashing when no result is returned.

waldyrious commented 7 years ago

Thanks for the contribution! I will do a proper review as soon as possible.

waldyrious commented 7 years ago

@Jan-Ka many apologies for not getting back to you sooner. I went through the changes and they all look good to me (nice work on the separation of commits, by the way!).

I've tested this on http://rawgit.com/Jan-Ka/primerpedia/gh-pages/index.html (since directly loading https://jan-ka.github.io/primerpedia triggers mixed content errors and fails to load external resources), and apart from a minor change in vertical spacing, the result is pretty much as expected. Great work on handling the "not found" case!

Again, sorry for not reviewing earlier. I'll add you as a collaborator in case you'd like to play around some more :)

Jan-Ka commented 7 years ago

Thank you very much @waldyrious ! Always glad to help!