search

waldyrious / primerpedia

Simplified extracts of Wikipedia articles, showing just the basic information.
https://primerpedia.toolforge.org
Other
11 stars 7 forks source link

Change preloader image #30

Closed ErdtR closed 7 years ago

ErdtR commented 7 years ago

Related to issue #29 @waldyrious can you check this?

waldyrious commented 7 years ago

Thanks for tackling this! For reference, here's a link to test these changes live: http://rawgit.com/ErdtR/primerpedia/change-preloader-img/index.html

I'd ask you to scale the image up a bit, perhaps using em units so that it automatically scales with the text size / line height, which is dynamic and dependent on the size of the container.

Also, please adjust the comment above the image to point to the new source location.

Finally, make sure the final commit message contains the string "fixes #29", so that github automatically closes the issue when this PR is merged, and shows backreference links in both places.

ErdtR commented 7 years ago

@waldyrious I made all changes

waldyrious commented 7 years ago

Looks good, thanks! :+1: