waleedev01 / analytics_automated_v2

Middleware layer for exposing analytics and distributed computing jobs as web services
Other
1 stars 0 forks source link

Extract and store requirement field in commandLineTool #48

Closed Cenxn closed 2 months ago

Cenxn commented 2 months ago

Since CWLSchemaValidator automatically verifies that the file conforms to the cwl syntax and the required data types, storing it as a JSON payload shouldn't cause serious problems in type constraint.

anisahn09 commented 2 months ago

I just realised workflow can also has "requirements" filed. Should we separate the model or how do you think? @Cenxn

waleedev01 commented 2 months ago

yes, @anisahn09 we will probably have to add requirements and hints json fields to job as well.

anisahn09 commented 2 months ago

yes, @anisahn09 we will probably have to add requirements and hints json fields to job as well.

I see, is there also "hints" for task?

anisahn09 commented 2 months ago

yes, @anisahn09 we will probably have to add requirements and hints json fields to job as well.

Also if there will be two requirement tables, maybe we should name them in the same way. Like Requirement_Task and Requirement_Job, or something like that. How do you think? @Cenxn @waleedev01

waleedev01 commented 2 months ago

yes, @anisahn09 we will probably have to add requirements and hints json fields to job as well.

Also if there will be two requirement tables, maybe we should name them in the same way. Like Requirement_Task and Requirement_Job, or something like that. How do you think? @Cenxn @waleedev01

I guess we are using the requirements json field, so we don't need to manage this table name issue.

anisahn09 commented 2 months ago

yes, @anisahn09 we will probably have to add requirements and hints json fields to job as well.

Also if there will be two requirement tables, maybe we should name them in the same way. Like Requirement_Task and Requirement_Job, or something like that. How do you think? @Cenxn @waleedev01

I guess we are using the requirements json field, so we don't need to manage this table name issue.

Wait so there will be only one Requirement table? or two table, one for task, one for job?

waleedev01 commented 2 months ago

yes, @anisahn09 we will probably have to add requirements and hints json fields to job as well.

Also if there will be two requirement tables, maybe we should name them in the same way. Like Requirement_Task and Requirement_Job, or something like that. How do you think? @Cenxn @waleedev01

I guess we are using the requirements json field, so we don't need to manage this table name issue.

Wait so there will be only one Requirement table? or two table, one for task, one for job?

Requirements will be a json payload field in both tasks and Job, not a table.