search

waleedka / hiddenlayer

Neural network graphs and training metrics for PyTorch, Tensorflow, and Keras.
MIT License
1.79k stars 266 forks source link

Possible style misspelling #5

Closed themightyoarfish closed 5 years ago

themightyoarfish commented 5 years ago

https://github.com/waleedka/hiddenlayer/blob/3588dbfa81fc3b0954b6fc8c9f3c187a78e78e5e/hiddenlayer/graph.py#L324

Should this be dotted maybe? When I build_graph with a PyTorch model, I get

Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
Warning: gvrender_set_style: unsupported style doted - ignoring
philferriere commented 5 years ago

Misspelling, for sure. Thanks for bringing it to our attention, @themightyoarfish

waleedka commented 5 years ago

This is one of those cases where the bug is a feature :) The lines in the graphs are supposed to be solid, and that's how we display them in the home page and the demos. The misspelling of "dotted" caused the style to be ignored and the lines were drawn solid, as they should be. Fixing the misspelling caused the lines in the graphs to be dotted, which is not the desired outcome. I replaced with an explicit "solid" value to make the intent clearer.