search

waleedka / hiddenlayer

Neural network graphs and training metrics for PyTorch, Tensorflow, and Keras.
MIT License
1.79k stars 266 forks source link

"torch._C.Value has no attribute 'uniqueName'" Error running with PyTorch 1.2 #51

Closed cted18 closed 4 years ago

cted18 commented 5 years ago

PyTorch Version: '1.2.0a' Python: 3.6.8 Exception has occurred: AttributeError 'torch._C.Value' object has no attribute 'uniqueName' File "hiddenlayer/hiddenlayer/pytorch_builder.py", line 45, in <listcomp> return node.scopeName() + "/outputs/" + "/".join([o.uniqueName() for o in node.outputs()]) File "hiddenlayer/hiddenlayer/pytorch_builder.py", line 45, in pytorch_id return node.scopeName() + "/outputs/" + "/".join([o.uniqueName() for o in node.outputs()]) File "hiddenlayer/hiddenlayer/pytorch_builder.py", line 90, in import_graph hl_node = Node(uid=pytorch_id(torch_node), name=None, op=op, File "hiddenlayer/hiddenlayer/graph.py", line 143, in build_graph import_graph(g, model, args) File "visualizer.py", line 20, in <module> graph = hl.build_graph(model, input)

Works well with older version of PyTorch (0.4.1).

phillies commented 4 years ago

I can confirm that the PR fixes the issue with pytorch 1.2.0, @waleedka please merge and build new pip package

emjay73 commented 4 years ago

fyi, I changed UniqueName() to debugName() ref :https://github.com/microsoft/human-pose-estimation.pytorch/issues/122#issuecomment-532984020

g13e commented 4 years ago

any plan to merge this anytime soon?