search

waleedkadous / ansari-backend

Ansari is a helper for you to become a better Muslim
65 stars 12 forks source link

Add Continuous Integration Support #18

Closed abdullah-alnahas closed 3 months ago

abdullah-alnahas commented 4 months ago

As-Salamu Alaikum brother M Waleed.

This pull request begins implementing continuous integration, addressing issue #6.

Tasks:

I'd appreciate input on the code changes. Thank you!

gitguardian[bot] commented 4 months ago

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | | Generic Password | ca9aeaa39e9af4250739525221668029fff5666c | .github/workflows/python-app.yml | [View secret](https://github.com/waleedkadous/ansari-backend/commit/ca9aeaa39e9af4250739525221668029fff5666c#diff-d7b3e1cc0b909c52439e5d8d3f602f70644d0f6b62a54825968d819f7a5bee89L29) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | | Generic Password | 76e73a38502874b3fe8024f59c2a57bdf5a80eb2 | .github/workflows/python-app.yml | [View secret](https://github.com/waleedkadous/ansari-backend/commit/76e73a38502874b3fe8024f59c2a57bdf5a80eb2#diff-d7b3e1cc0b909c52439e5d8d3f602f70644d0f6b62a54825968d819f7a5bee89L27) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | | Generic Password | ca9aeaa39e9af4250739525221668029fff5666c | .github/workflows/python-app.yml | [View secret](https://github.com/waleedkadous/ansari-backend/commit/ca9aeaa39e9af4250739525221668029fff5666c#diff-d7b3e1cc0b909c52439e5d8d3f602f70644d0f6b62a54825968d819f7a5bee89L55) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | | Generic Password | ca9aeaa39e9af4250739525221668029fff5666c | .github/workflows/python-app.yml | [View secret](https://github.com/waleedkadous/ansari-backend/commit/ca9aeaa39e9af4250739525221668029fff5666c#diff-d7b3e1cc0b909c52439e5d8d3f602f70644d0f6b62a54825968d819f7a5bee89L68) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | | Generic Password | ca9aeaa39e9af4250739525221668029fff5666c | .github/workflows/python-app.yml | [View secret](https://github.com/waleedkadous/ansari-backend/commit/ca9aeaa39e9af4250739525221668029fff5666c#diff-d7b3e1cc0b909c52439e5d8d3f602f70644d0f6b62a54825968d819f7a5bee89L69) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | | Generic Password | ca9aeaa39e9af4250739525221668029fff5666c | .github/workflows/python-app.yml | [View secret](https://github.com/waleedkadous/ansari-backend/commit/ca9aeaa39e9af4250739525221668029fff5666c#diff-d7b3e1cc0b909c52439e5d8d3f602f70644d0f6b62a54825968d819f7a5bee89L54) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | | Generic Password | ca9aeaa39e9af4250739525221668029fff5666c | .github/workflows/python-app.yml | [View secret](https://github.com/waleedkadous/ansari-backend/commit/ca9aeaa39e9af4250739525221668029fff5666c#diff-d7b3e1cc0b909c52439e5d8d3f602f70644d0f6b62a54825968d819f7a5bee89R27) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

abdullah-alnahas commented 4 months ago

@waleedkadous I have completed all the tasks outlined in the initial comment.

Could you please review the changes and provide your feedback and guidance on the next steps? I'm happy to make any further adjustments or address any concerns you may have.

Jazakallahu khayran.

Update: I have tested everything locally with act and the CI/CD job succeeds.