search

walkable-server / walkable

A Clojure(script) SQL library for building APIs: Datomic® (GraphQL-ish) pull syntax, data driven configuration, dynamic filtering with relations in mind
https://walkable.gitlab.io/
Eclipse Public License 2.0
444 stars 15 forks source link

Spec about the floor-plan #154

Closed zerg000000 closed 3 years ago

zerg000000 commented 5 years ago

I hit several times that, making change to floor plan cause a lot of un-obvious exceptions. like emitter is mandatory, some options if defined, it must have at least one item. I think a spec maybe useful in this case, make the user experience much better.

myguidingstar commented 5 years ago

sorry for the experience. I totally agree. The problem is floor plan is quite big, and I've split the processing pipeline into quite a few smaller functions. I guess it will work with spec2's select so I am kinda waiting. Without spec2/select, the number of specs can be tremendously large. That being said, it's still valuable to spec as many of them as possible.

zerg000000 commented 5 years ago

I am totally okay to wait for spec2, as I am waiting for spec2 too.

myguidingstar commented 3 years ago

New public api has been merged to master. I found a way around with spec1. The public api is simpler, floor-plan now becomes an internal thing.

myguidingstar commented 3 years ago

to give feedback on errors, guardrails will be used. #87