search

walkable-server / walkable

A Clojure(script) SQL library for building APIs: Datomic® (GraphQL-ish) pull syntax, data driven configuration, dynamic filtering with relations in mind
https://walkable.gitlab.io/
Eclipse Public License 2.0
444 stars 15 forks source link

First documentation result incorrect? #164

Closed teodorlu closed 4 years ago

teodorlu commented 4 years ago

Hello!

This is the first documented result:

{[:person/by-id 1]
 {:person/id   1
  :person/name "Mary"
  :person/age  20
  {:person/pet {:pet/name              "Tom"
                :pet/favorite-location "garden"}}}}

As far as I can see, that contains a map with an odd number of elements in it. An error, perhaps?

Have an otherwise nice day, Teodor

myguidingstar commented 4 years ago

Nice catch! The documentation source is here, contribution is highly welcome https://github.com/walkable-server/docs

teodorlu commented 4 years ago

Cool!

I'd love to contribute, but frankly, not having used walkable, I don't know what it should be.

Is this right?

{[:person/by-id 1]
 {:person/id   1
  :person/name "Mary"
  :person/age  20
  :person/pet  {:pet/name              "Tom"
                :pet/favorite-location "garden"}}}
myguidingstar commented 4 years ago

Yup, that's correct

teodorlu commented 4 years ago

I'll send a PR :)

teodorlu commented 4 years ago

PR: https://github.com/walkable-server/docs/pull/1

Closing this!