walkamongus / puppet-harbor

Puppet Harbor module
https://forge.puppet.com/walkamongus/harbor
4 stars 7 forks source link

Add various improvements #1

Closed martialblog closed 5 years ago

martialblog commented 5 years ago

Hello,

I've added some stuff:

The setting was < 5.0.0, but the stdlib is at 5.2.0 currently. Now the warning is gone and the installation runs without issues.

This ensures the integrity of the package and addresses malicious tampering. I also updated to 1.7.5, which required an extra parameter (release), since the download URL is:

https://storage.googleapis.com/harbor-releases/release-1.7.0/harbor-offline-installer-v1.7.5.tgz

By adding puppetlabs-apt and updating the exec resource. Tested that in Vagrant, works like a charm :whale:

You can drop these is you want, just thought it might be nice to have.

Cheers, Markus

walkamongus commented 5 years ago

awesome -- thanks @martialblog!