walkamongus / puppet-harbor

Puppet Harbor module
https://forge.puppet.com/walkamongus/harbor
4 stars 7 forks source link

Implement settings migration for Harbor v2 #40

Closed entasisj closed 3 years ago

entasisj commented 3 years ago

I noticed that the Harbor v2 upgrade guide mentions changes for the settings migration. Note that the Docker image goharbor/harbor-migrator:VERSION is not available anymore with Harbor v2. I further noticed that the refreshonly configured exec resource in harbor::config was never executed because the class harbor::config is never notified. Additionally I noticed that there was the erroneous option '-it' in the migration 'docker run' command which makes the exec resource fail with error "the input device is not a TTY" and the tag of the Docker image missed the leading v character.