search

walkamongus / puppet-harbor

Puppet Harbor module
https://forge.puppet.com/walkamongus/harbor
4 stars 7 forks source link

Separate and share duplicated code in providers #42

Closed entasisj closed 3 years ago

entasisj commented 3 years ago

The providers duplicate code to login into Harbor registry using the swagger client. I added specific module and class in lib/puppet_x as recommended (as far as I was able to found examples) which the providers now call.

walkamongus commented 3 years ago

@entasisj 👍 will cut a new release as soon as I can

entasisj commented 3 years ago

Please wait with the release. I currently noticed an issue with the provider of type harbor_project. The attributes public and auto_scan are not read from registry resulting in a repeated corrective configuration of the affected attributes. I'm investigating.

entasisj commented 3 years ago

I created pull request https://github.com/walkamongus/puppet-harbor/pull/44 to resolve the observed issue.

walkamongus commented 3 years ago

are you comfortable with me releasing after merge?

entasisj commented 3 years ago

Oh yes. :)