Add feature for some kind of Approval

walkasjesus commented 5 years ago

When a user has access, he can just change commandments and bible verses without consensus. Therefore there should come some kind of approval support for models.

walkasjesus commented 5 years ago

There are multiple extensions for this feature. Which one do we choose?

walkasjesus commented 5 years ago

https://pypi.org/project/django-moderation/ looks best I think

walkasjesus commented 5 years ago

For me this is a little bit too complex to integrate in the model, it would be very nice if you @Ikbengeenrobot could have a look at it? This feature is mandatory to open the admin panel also for other users. The first person is already busy with studying the commandments :-)

Ikbengeenrobot commented 5 years ago

It looks like https://pypi.org/project/django-moderation/ does not support django 2. Did you have alternative ideas, or what features did make you prefer this one?

Ikbengeenrobot commented 5 years ago

In case we cannot find something out of the box (which would be the preferred choice of course);

Then maybe it is not to hard too build something myself, what requirements do we have? I would propose building something not to complex like like:

Editing an model will result in a change request
Change request are shown on separate page
Change request can be approved or deleted
Approval page will show current value, and change (request) value
No support to merge multiple changes on the same field (of course nice, but would be quite hard)

walkasjesus commented 5 years ago

Okay I see! Really, man, how amazing that you even think of building this yourself. For the requirements I don't think we need much more than you mention. A email notification for the moderators would be nice too.

When I search through the internet I also saw this: https://github.com/viewflow/viewflow/ http://docs.viewflow.io/index.html I'm not sure if this contains what we are looking for, or maybe this is far too big and complex?

A separate issue would be to improve the registration process. Currently this has some limitations:

Extend form with email, firstname, lastname, gender, terms ans conditions
email confirmation
email notification to moderator that a user is registered

Since this looks quite good possible with this viewflow, maybe it is worth to take a good look at it, so we can use multiple things from them? This registration form is perfect by example: http://demo.viewflow.io/materialforms/registration/

I already tested a little bit with the https://materializecss.com, and that seems to work.

Of course one step at the time. But good to consider the options.

walkasjesus commented 5 years ago

I also found this by the way: https://github.com/artscoop/django-approval

Ikbengeenrobot commented 5 years ago

Found something interesting, it seems there is a different page with documentation, I do not know if this is a fork or the other docs are outdated, but this one seems to support Django 2, so I will give it a try. https://django-moderation.readthedocs.io/en/latest/

Ikbengeenrobot commented 5 years ago

No, does not work, there was a pull request done from another developer to support django 2, but is is buggy and not easy to get to work.

Ikbengeenrobot commented 5 years ago

Trying django-approval now

walkasjesus commented 5 years ago

Ok great

Ikbengeenrobot commented 5 years ago

Cannot get django-approval running, seems there are not many stable packages for this feature.. will continue searching :)

walkasjesus commented 5 years ago

Mm ok too bad. And have you looked at https://github.com/viewflow/viewflow/? Or is that too large?

Ikbengeenrobot commented 5 years ago

What I build now might be a nice start. I have no approval model, but I made a changelog page, that shows all changes made and who made them. A change can be reverted. The library we use also has a possibility to show a model at a certain point in time. So we can extend use the feature to make a sort of approval model.

So we set the approved date to 12-oct We show all models on the site at the history point 12-oct We make changes. Changes are not visible because the aproved day is 12-oct We remove unwanted changes and set the approved day to 14-oct Now the site will show the changes at 14-oct.

I still have to build this proposal, but it won't be too hard, we still need to add extra rights such that only admin can change history and approve etc.

walkasjesus commented 5 years ago

Very smart approach! I tested you branch on acceptance, the changelog works great. Nice progress!

walkasjesus commented 4 years ago

Instead of Addding feature for some kind of Approval, we decided to achieve the same kind of result in a different approach. We will try to:

Enable changelog functionality (#100)
Split CSV import into multiple csv's (#102)
Export to CSV function (#103)

If we got all of these, we can hopefully create a nice workflow to update the content of the site

walkasjesus / walkasjesus_framework

Add feature for some kind of Approval #21