search

walkerke / mapboxapi

R interface to Mapbox web services
https://walker-data.com/mapboxapi/
Other
109 stars 8 forks source link

resolve attribution for `layer_static_mapbox` + updated docs + add tests #25

Closed elipousson closed 2 years ago

elipousson commented 2 years ago

This pull request is intended to resolve attribution and license compliance issues for layer_static_mapbox (see #24). While I was making these changes, I made extensive small changes to the formatting of the documentation and added numerous links back to the Mapbox API documentation.

I also added add tests for the styles functions (primarily just to make sure I set up testthat and the skip_if_no_token helper function directly.

Lastly, this fixes an error with the style_url parameter due to the previously unnamed second parameter of stringi::str_extract (now updated to be correctly named regex). See the set_static_map_style helper function for an example of this change.

elipousson commented 2 years ago

If you’d rather I make a more basic, easier to review pull request that only addresses the attribution issue and saves the documentation updates for a separate pull request, please let me know @walkerke!

walkerke commented 2 years ago

@elipousson this is great, just haven't had the time to review. Should be able to take a look this week or next!