walkerke / mapgl

R interface to Mapbox GL JS v3 and Maplibre GL JS
https://walker-data.com/mapgl
Other
84 stars 3 forks source link

fix namespacing in proxy functions for shiny apps with modules #15

Closed RWParsons closed 2 months ago

RWParsons commented 2 months ago

Hi @walkerke,

This PR addresses the first problem encountered and discussed in #12 - that there is a namespacing issue when using the mapgl_proxy() or maplibre_proxy() functions in a modularised shiny app. This was first problematic when changes would not occur on the map when trying the set_filter() via mapgl_proxy() on this test app.

It passes a devtools::check() but I'm not sure how thorough this is of a check as there isn't currently a testing suite.

Cheers, Rex