walkermatt / ol-layerswitcher

Layer control for OpenLayers
MIT License
387 stars 176 forks source link

Modifications to click activation & panel styling #358

Closed petergoulborn closed 4 years ago

petergoulborn commented 4 years ago
    • New option to start with panel open.
    • Move button outside of panel when using click activation (see examples)
    • Changes to layer & group name alignment (when wrapping align with beginning of name).
    • Minor editing to README.md
walkermatt commented 4 years ago

Do you have a link to an example that demonstrates the changes?

petergoulborn commented 4 years ago

Alignment changes

Mostly just getting layer group names to indent when wrapping, as per layer names Before: image

After: image

walkermatt commented 4 years ago

Sorry to be a pain, can the format changes could be split out into a separate PR? It's making it very difficult to see the functional changes.

petergoulborn commented 4 years ago

I've rolled back a couple of changes that were just muddying the water and merged upstream master.

walkermatt commented 4 years ago

@devsupportman I've a bunch of tests ready to commit tomorrow morning then I think we're good 👍

There are a few other changes such as improving the names of options and CSS classes but I think we should roll those into the next major version.

I also think we should add aria-label attribute to the button with the same value as the title attribute as the button doesn't have readable text content.

petergoulborn commented 4 years ago

Looks good to me