muhammad23012009
commented
1 year ago Hi. I've finally got around to this PR. I'm sorry, it just happened to slip out of my mind.
Here are some things I've done:
- I moved the WayDroid category into System. I think a separate category for it was a bit too much, though dumping everything into "System" is questionable as well... I don't really know what to do, but hiding some options when it's not applicable may declutter them, giving us more time to plan out a better category system. What are your thoughts on the matter?
- I've slightly reworked the logic for WayDroid fetching to my liking. If you see any more ways to make this code briefer, clean, more Pythonic or reliable, let me know! I don't currently have a Waydroid-compatible device to test it, so let me know if it breaks.
Also, I guess a 20.04 build pipeline could be set up. Since little to no changes were yet made to the
Ubuntu.Componentsexcept the Lomiri rename, maybe we could avoid having a separate branch. What do you think?Once again, thanks for the contribution! I really appreciate all the help.
Hi! In my opinion we should keep the WayDroid tab, since it doesn't really fit in the System tab as it's not a critical OS part, rather it's a piece on its own. Its own category would allow us to add even waydroid dependencies versions (which I'm also working on) For 2 I'm still thinking about it, but it looks good enough for now
Hi. I've finally got around to this PR. I'm sorry, it just happened to slip out of my mind.
Here are some things I've done:
I moved the WayDroid category into System. I think a separate category for it was a bit too much, though dumping everything into "System" is questionable as well... I don't really know what to do, but hiding some options when it's not applicable may declutter them, giving us more time to plan out a better category system. What are your thoughts on the matter?
I've slightly reworked the logic for WayDroid fetching to my liking. If you see any more ways to make this code briefer, clean, more Pythonic or reliable, let me know! I don't currently have a Waydroid-compatible device to test it, so let me know if it breaks.
Also, I guess a 20.04 build pipeline could be set up. Since little to no changes were yet made to the
Ubuntu.Componentsexcept the Lomiri rename, maybe we could avoid having a separate branch. What do you think?Once again, thanks for the contribution! I really appreciate all the help.