search

walkmod / walkmod-pmd-plugin

Walkmod plugin to fix the code according the PMD rules
2 stars 2 forks source link

bad interaction between "remove unused" constant and "merge if conditions" #9

Closed cal101 closed 7 years ago

cal101 commented 7 years ago 
-    private static final boolean ENABLE_CHECK = false;

...

     private void assertIsReadMode() {
-        if(ENABLE_CHECK) {
-            if(!isTestMode.isTrue()) {
-                if(log.isDebugEnabled()) {
-                    log.debug("assertIsReadMode %s", super.toString());
-                }
-                Assert.assertTrue("is not read only", readOnly);
+        if(ENABLE_CHECK && !isTestMode.isTrue()) {
+            if (log.isDebugEnabled()) {
+                log.debug("assertIsReadMode %s", super.toString());
             }
+            Assert.assertTrue("is not read only", readOnly);
         }
     }