walkor / phpsocket.io

A server side alternative implementation of socket.io in PHP based on workerman.
2.3k stars 508 forks source link

Update to socket v4 #284

Open wilianmaique opened 1 year ago

wilianmaique commented 1 year ago

many things have been improved, what do you think about updating to the latest?

https://socket.io/docs/v4/server-api/

marcosmarcolin commented 1 year ago

https://github.com/walkor/phpsocket.io/issues/262

binemmanuel commented 1 year ago

We don't have a choice but to make the upgrade ourselves and create a PR since our applications depend on it

wilianmaique commented 1 year ago

We don't have a choice but to make the upgrade ourselves and create a PR since our applications depend on it

I don't have that much knowledge, but I could run tests etc, report bugs etc, someone needs to do this, and make it open source, it's very good

PhilLehmann commented 1 year ago

I would definetly be interested. This would enable me to use ngx-socket-io in the latest version, which is required when you want to use the latest angular version.

For now, I will just use the original library socket.io-client as a fallback, but i would definetly support (beta) testing if you PR phpsocket.io with socket.io v4 support.