search

walkor / phpsocket.io

A server side alternative implementation of socket.io in PHP based on workerman.
2.3k stars 508 forks source link

refactor: code improvements without affecting logic, part 4. #300

Closed marcosmarcolin closed 11 months ago

marcosmarcolin commented 12 months ago

Hello,

I'm proposing some improvements in the quality of the code, as we don't have a test suite at the moment, I'm testing it on a real application and it's working correctly.

@walkor The engine you transcribed the code from https://github.com/socketio/engine.io/tree/2.1.x, right?

Did you base the other parts on any other socket.io server development or did you develop them yourself?

I ask this because I'm interested in trying to make the package comply with version 3 of socket.io first.

Thanks.

walkor commented 11 months ago

Yes, I transcribed the code directly from https://github.com/socketio/engine.io and https://github.com/socketio/socket.io, but I'm not sure about the specific version numbers. It would be great if you could implement version 3 of socket.io.

walkor commented 11 months ago

I have added you to the project, and of course, you can also create a separate project. I will include a link to your project in this one.

marcosmarcolin commented 11 months ago

Hello,

Thank you very much for your trust.

I'm going to dedicate some time to this, as much as possible I hope to help make it compatible with newer versions.