search

walkor / phpsocket.io

A server side alternative implementation of socket.io in PHP based on workerman.
2.3k stars 508 forks source link

feat: add compatibility for PHP 8.2 #304

Closed i-derevianko closed 6 months ago

marcosmarcolin commented 6 months ago

Hello @i-derevianko, firstly, thank you for your PR!

The user tested previous versions and confirmed that the code worked correctly.

What was the error that prompted the PR? Undefined properties?

For me, LGTM.

@walkor Do you agree?

i-derevianko commented 6 months ago

Hi @marcosmarcolin! Yeah, undefined properties mostly, and problem with the parent class calling.

i-derevianko commented 6 months ago

@marcosmarcolin @walkor

Found some problem. There is differences between release v2.0.3 and repo.

For example https://github.com/walkor/phpsocket.io/blob/master/src/Engine/Socket.php#L24

There is public $upgradeTransport = null; public $transport = null;

But there is no this attributes in release v2.0.3. Check it please before merge.

marcosmarcolin commented 6 months ago

@i-derevianko

Yes, after version v2.0.3 there were changes to the code, but a version was not released.

We can see all the changes after the mentioned version here: https://github.com/walkor/phpsocket.io/compare/v2.0.3...master

@walkor I just released version v2.0.4 with the new changes.

walkor commented 6 months ago

@i-derevianko Thank you for your PR.

@marcosmarcolin That great , thank you for your release.

marcosmarcolin commented 6 months ago

Thanks @i-derevianko!

Released v2.1.0