search

walkor / webman-framework

webman-framework
116 stars 57 forks source link

Breaking change in app v1.4 #54

Open joanhey opened 2 years ago

joanhey commented 2 years ago

TypeError: Webman\App::__construct(): Argument #1 ($request_class) must be of type string, Workerman\Worker given, called in /webman/start.php on line 55 and defined in /webman/vendor/workerman/webman-framework/src/App.php:96

Also the new App construct have no container. Incompatible webman-framework and webman.

https://github.com/walkor/webman-framework/blob/master/src/App.php#L96 https://github.com/walkor/webman/blob/master/start.php#L97

And it's a breaking change, so need to be a major version and not a minor version (1.4)

walkor commented 2 years ago

I'm very sorry for the inconvenience. Please execute the command to install version 1.4. composer require webman/console ^1.0.27 && php webman install

You're right. I'll pay attention next time。

joanhey commented 2 years ago

Sorry but it's NOT working. When the benchmark fail, it's for a breaking change, that affect all the apps outside from the bench. I try my best with any new php version, but webman still fail without any php version change.

joanhey commented 2 years ago

@walkor go to the Techempower benchmark and fix Webman. Thank you.

walkor commented 2 years ago

ok