search

walkor / workerman

An asynchronous event driven PHP socket framework. Supports HTTP, Websocket, SSL and other custom protocols.
http://www.workerman.net
MIT License
11.03k stars 2.25k forks source link

Events finalize #981

Closed luzrain closed 8 months ago

luzrain commented 8 months ago

I suggest to finalize Event classes. Inheritance for them seems not very much useful and even unwanted since we have Interface. User can implement Interface and use own implementation if it needed instead of inheriting from package implementations.
I believe it's possible now while version 5 is still in beta. I also suggest to remove getErrorHandler method from Interface since it don't used here.

luzrain commented 8 months ago

Seems it has broken windows-php8.3 test 🤔 It's strange.

PS. Just not very stable tests. rerun has solved it.