Issue #21: Refactor for testing

walktalkchalk / TabStache

A chrome extension for saving and recalling tabs in a stash

GNU General Public License v2.0

2 stars 10 forks source link

Issue #21: Refactor for testing #24

Closed btruhand closed 6 years ago

btruhand commented 6 years ago

Hi I've made the PR for the issue. There are two things I want to note:

My development setting is 2 spaces instead of 4 spaces. In case you want me to change it just tell me
Not related to my changes I think but when you try to stache tabs that only consists of ignored tabs or blank tabs when you try to unload the stache, the stache list won't be updated. It seems to exist in the current version too. Though it is kind of useless to stache such tabs, so probably not much of an issue

btruhand commented 6 years ago

@dngrhm forgot to set the reviewer so feel free to add yourself

dngrhm commented 6 years ago

Awesome! @btruhand Initial peek looks good. I'll look into it a little more deeply when I get a chance. I prefer 2 spaces, so you're good there! 👍 Thanks for the PR submission and good luck with the rest of Hacktoberfest

btruhand commented 6 years ago

@dngrhm alright 👍 tell me if you have any concerns

dngrhm commented 6 years ago

@btruhand Thanks for the PR. Good luck in your Hacktoberfesting!!