search

walkxcode / dashboard-icons

🚀 The best source for dashboard icons.
Other
4.85k stars 521 forks source link

Firefly III svg broken? #421

Closed Skaronator closed 1 year ago

Skaronator commented 1 year ago

Icon Name

https://github.com/walkxcode/dashboard-icons/blob/main/svg/firefly.svg

The icon seems to be broken. Even GitHub preview will show an empty image: image

It's there when you open the file fullscreen/RAW but seems like it's out of the "box".

When using the Icon in Homepage I get an empty Icon

image

Icon(s)

No response

walkxcode commented 1 year ago

I will take a look at this in a couple of days!

Skaronator commented 1 year ago

zigbee2mqtt.svg is also broken. It looks like the CI commit broke it because a previous version looks fine:

Previous: https://github.com/walkxcode/dashboard-icons/blob/9d9e48b7c05ad5a57d2d91e037dac07d062de244/svg/zigbee2mqtt.svg Current: https://github.com/walkxcode/dashboard-icons/blob/main/svg/zigbee2mqtt.svg

walkxcode commented 1 year ago

Yup.. I think you are right. Do you know of an easy way to revert all SVGs (except completely new ones) back to their versions before the CI changes?

Skaronator commented 1 year ago

If it's just that single commit that causes all the changes then I think git reset for the SVG folder one commit before that would be enough:

https://stackoverflow.com/a/6119127

Cannot test or check since I'm on my phone.

Skaronator commented 1 year ago

Just asked chatGPT and yeah git revert instead of reset would be easier. (git reset would also work but more commands)

To revert a commit for a specific folder in Git, follow these steps:

  1. Identify the commit hash that you want to revert. You can do this by running git log and copying the hash code of the commit that made changes to the folder.

  2. Run the git revert command and provide the commit hash. For example, to revert commit "abcd123" for a folder named "my-folder", run: 

git revert abcd123 -- my-folder

  1. Git will open a new file where you can enter your commit message. You can leave this file as it is and save it.

  2. Push the changes to your Git remote repository using the git push command.

This will undo the changes made by the specified commit in the specified folder.

walkxcode commented 1 year ago

Wouldn't this also remove all the new SVGs that I have added manually?

Skaronator commented 1 year ago

Mh yeah. That's why separating different stuff into separate commits is important 😅

walkxcode commented 1 year ago

It is different commits, I am just wondering if this will reset all the way back to that commit, or will it just revert that single commit.

Skaronator commented 1 year ago

It will just revert that single commit. You might have merge conflicts but that should be easily resolvable

walkxcode commented 1 year ago

I am unable to just revert the SVG folder, and I'm having loads of trouble resolving merge conflicts. Can someone help me with this?

I'm gonna manually redownload the SVGs from older versions and merge in all commits (except SVG compressions) after that.