github-actions[bot]
commented
4 months ago This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself
About The Pull Request
I want to fix up unit tests as best I can so I can start to rely on them to catch issues
Fixes some errors with shuttle windows and door timers
Fixes all fixable wall icon state test failures
fixes newscaster frame not drawing right
Fixes window/grille missing icon state errors
Removes redundant smoothing define set
Implements tram alt walls properly
Cleans up a few more window/wall icon states
Adds temp? autoalign to firedoors
Properly names fencedoor's closed state
updates railing sprites to match the new format (maybe)
Adds the cache folder to gitignore 98a1357
This should really be done as a merge from master but I don't have the time for that. This'll prevent annoyance for devs working on branches between tg and wallening
Removes underfrills, rejigs frills and frill masks to prevent double drawing in case of transforms 1bea6bd
The underfrill didn't really do anything, since we can make the frill mask transparent to get its visual effects, and we can't direct clicks to the wall anyway since these overlays get drawn to the floor. This simplifies splitvis and rendering a bit, which is nice