search

wall-nerds / wallening

A group of /tg/station devs attempt to 3/4thify ss13
https://www.tgstation13.org/
GNU Affero General Public License v3.0
9 stars 4 forks source link

Status Displays need fixing #226

Open san7890 opened 1 month ago

san7890 commented 1 month ago

https://github.com/tgstation/tgstation/pull/83296 Changed how status display overlays work but we still have a bunch of logic (e.g. modifying the text matrix and glow) on this repository that just needs to be addressed. I tried to merge master earlier but I got pretty stuck on figuring out what the new logic was trying to accomplish, just needs an audit to make sure it works with the new system of string keys -> overlays. i'll try again later but just putting it here so people are in the loop

ArcaneMusic commented 3 weeks ago

Additional note: On testing (6-11), we had some status visuals like this where the display overlayed the consoles image The status doesn't block the computer from being used, intentionally, but it can look a bit cluttered

san7890 commented 3 weeks ago

@Tastyfish are you still around/have time to fix up your project? it's clear that you wanted a certain effect done and it'd be nice to see the vision be fully realized rather than potentially get axed or altered

LemonInTheDark commented 3 weeks ago

Additional note: On testing (6-11), we had some status visuals like this where the display overlayed the consoles image The status doesn't block the computer from being used, intentionally, but it can look a bit cluttered

we should prob implement like a blinking effect or something for this

Tastyfish commented 3 weeks ago

@Tastyfish are you still around/have time to fix up your project? it's clear that you wanted a certain effect done and it'd be nice to see the vision be fully realized rather than potentially get axed or altered

I don't do ss13 development that much anymore, but I can take a look and see if I can merge the tg overlay key changes to here since I will hopefully understand it better.

Additional note: On testing (6-11), we had some status visuals like this where the display overlayed the consoles image The status doesn't block the computer from being used, intentionally, but it can look a bit cluttered

we should prob implement like a blinking effect or something for this

Regarding the overlapping objects thing, yeah not really sure what the best way to handle that would be. I think under any visual solution, east/west status displays need to not be crowded.

Flickering might be workable solution, but I think we might step strongly into the territory of the text being completely unreadable. Granted you can always examine the status display.