Bunch of individual changes, alongside pulling in some new sprites

[LemonInTheDark]

About The Pull Request

Just a ton of small changes I've had cooking for the past few weeks. Contains sprites from Draco and Meyhazah. I've also taking the liberty of fully implementing some sprites added recently, and have resurrected viro's sign sprites.

Adds 4 corner style airlocks (centcom and maint) alongside morge sprites (draco)

Adds construction sprites to gags, adds support for inheriting airlock stuff to assemblies

Cleans up greyscale application, adds unit test

I want to test for airlock icon states, so I don't miss shit or anythin

adds a construction state to windowed airlocks

Adds construction states to a bunch of airlocks, fixes a few small issues

Readds viro's sign sprites

82

This change got dropped YEARS ago because I merged it into experimental incorrectly and then never pulled that over to stable. I am a fool

I've added all the missing sprites in the same style, so we should be all good now

Moves material airlocks to the new system

Trivial, we just give them the default config and extend their colors to match the length required.

Also resolves a few bugs with the airlock typepath handling stuff

adds table buttons (meyhaz)

I've added a bunch of subtypes to make this work, please advise map people.

Cleans up a few airlocks

Highsec and vault had a trim on the directionals that didn't quite work

Wood was shifted right one on opened which lead to a weird jumping effect

Shuttle had its center inconsistent, and had a fill improperly inserted in some of the animations.

Mourge had a 0.5 second delay on the start of opening which seemed... odd

Implements new shutters (draco)

Adds nuclear and seethrough shutters

Implements emissives for shutters so they look nice in the dark

Fills out most all of the remaining material doors (meyhaz)

Still missing resin, we'll see what baron's alien walls look like.

Implements proper delays for the mourge airlock, takes animation delay variation into account for wait times

Removes the greyscale test airlocks (testing DONE!)

Adds cult runed airlock closing animation (draco)

Removes edging from puzzledoors, converts then to open_top/bottom

Converts mineral doors to open_top/bottom

Implements variable open delays, expands implementations c8ce3c2

Airlock opening delay should vary with how long the animation actually takes (since people are playing with them now). This does mean if you give me a 3 second opening animation that fucker will take 3 seconds to open.

Implements that here and for doors. Adds delay handling to the hatches, vault/highsec and cult doors.

[san7890]

You asked for my thought on table buttons and I'm stuck wondering if the pattern can't be... better somehow... it's obvious we need table buttons but I just can't stop thinking about if there would be a better way to accomplish it. are you able to split that out into another PR? i don't want to hold up this one while i think on a better way to tackle it (and we can just send that PR through if I can't figure it out)

[LemonInTheDark]

You asked for my thought on table buttons and I'm stuck wondering if the pattern can't be... better somehow... it's obvious we need table buttons but I just can't stop thinking about if there would be a better way to accomplish it. are you able to split that out into another PR? i don't want to hold up this one while i think on a better way to tackle it (and we can just send that PR through if I can't figure it out)

I absolutely could if that's something you want. I am still working on stuff here that's fit with this pr though so it's no rush regardless.

[san7890]

splitting it out would just be nicer for scrolling through it repeatedly and dwelling on potential solutions while i think about it (less clutter with other changes) but it's up to whatever time you have

[LemonInTheDark]

I am a bit busy atm, but if that's what you're after I raise you https://github.com/wall-nerds/wallening/pull/237/commits/474104884264f78cebf726bdbb670ccb4f910e12

[san7890]

anyways my thoughts on directionals are it should be /obj/machinery/button/thing/table and not table/thing because having to scroll a massive thing of just /table stuff seems quite taxing on the mapping process, imagining the object tree in a map editor:

* /obj
 - /machinery
  - /button
   - /thing <- both directional walls and the table subtype are right here for this specific type!
    - /directional
    - /table 

It would even be less copypasta code because all we would need is MAPPING_TABLE_BUTTON_HELPER(/obj/machinery/button/thing) to set the icon states/dirs to make this work instead of copypasting the access and whatever, just one line. that's how i see it anyways, let me know if that's not feasible.

[LemonInTheDark]

anyways my thoughts on directionals are it should be /obj/machinery/button/thing/table and not table/thing because having to scroll a massive thing of just /table stuff seems quite taxing on the mapping process, imagining the object tree in a map editor:

* /obj
 - /machinery
  - /button
   - /thing <- both directional walls and the table subtype are right here for this specific type!
    - /directional
    - /table 

It would even be less copypasta code because all we would need is MAPPING_TABLE_BUTTON_HELPER(/obj/machinery/button/thing) to set the icon states/dirs to make this work instead of copypasting the access and whatever, just one line. that's how i see it anyways, let me know if that's not feasible.

I was concerned that sort of organization would be annoying, but I can 100% make that happen

[san7890]

it would be less annoying, see how "any" and "all" access helpers presently works.

[github-actions[bot]]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

[LemonInTheDark]

Table buttons should be better now