wall-nerds / wallening

A group of /tg/station devs attempt to 3/4thify ss13
https://www.tgstation13.org/
GNU Affero General Public License v3.0
10 stars 3 forks source link

Offset objects that instantiate / forcemove objects to their loc should also offset said items #317

Open MrMelbert opened 1 month ago

MrMelbert commented 1 month ago

See protolathes, (which are not currently offset but should be, this is VV'd). Printing objects doesn't put it where the protolathe is.

This is particularly a problem because, well, it looks bad. But also in testmerges, people report that sometimes it can dispense items under windows (if a window was present on on the south side), and be unclickable. Haven't been able to reproduce this but it's a common report.

image

Things affected

image

Things affected only if you go out of your way

Also:

image

And probably more... we instantiate a lot of objects

tontyGH commented 1 month ago

this might be a naive solution but couldn't you just set the base_pixel of /obj/item/ to the depth offset and fix all of these at once

tontyGH commented 1 month ago

^ tried this, looks pretty good and, aside from items going very slightly into walls when dropped, I couldn't find a situation in my like 5 minutes of testing that broke anything or looked bad