wallabag / android-app

Android application to read your articles saved in your wallabag. You can also easily add new articles.
https://www.wallabag.org
GNU General Public License v3.0
471 stars 259 forks source link

Update app icon and support the round icon of Android 7.1 #317

Open ghost opened 7 years ago

ghost commented 7 years ago

Besides the current material icon request in the app (#272 #273), I'd like to see an updated app icon as well. In my opinion a white "w" on a black background should be enough to recognize wallabag. And with Android 7.1 in sight, it would be useful to create an round icon as well :)

lokesh-krishna commented 7 years ago

What are the specifications an icon should meet for Android? I believe any number of icon pack developers for GNU/Linux wouldn't mind making an icon as long as they're provided with the exact specifications. I've been waiting a long time to see a Material Design app icon.

ghost commented 7 years ago

I think this is the right documentation for it: https://material.google.com/style/icons.html#icons-system-icons

lokesh-krishna commented 7 years ago

Thank you so much! I'll contact an icon pack developer to see what can be done :)

tcitworld commented 7 years ago

Also, maybe icon shortcuts.

lokesh-krishna commented 7 years ago

@tcitworld I don't think that's something an icon designer should be doing. A separate issue maybe?

varlesh commented 7 years ago

image

Wallabag.zip

tcitworld commented 7 years ago

I really like the general aspect, but could the wallaby be just a little less large ? A thousand thanks for your work.

varlesh commented 7 years ago

you mean large "W"? Soryy my English very bad ;)

tcitworld commented 7 years ago

Apologies. I had found the kangaroo itself a bit large at first on your picture, but in fact it's because of the way it's stylized on our own logo with the "w" :

tcitworld commented 7 years ago

Suits me well on second look. :)

ghost commented 7 years ago

And what do you guys think about the plain "w" (with a long shadow) on a black background?

varlesh commented 7 years ago

Ok. I use #2780e3 color for circle background - it's your main color on site.

varlesh commented 7 years ago

Black not good for material... IMHO

ghost commented 7 years ago

I get your point. However, I'm unsure if #2780e3 or #00bcd4 should be used, the latter is used on the web interface of wallabag. Which color do you prefer @tcitworld @nicosomb @j0k3r?

varlesh commented 7 years ago

Maybe merge colors... image

varlesh commented 7 years ago

Also for better looking we can add shadow effect for kangoo :) For example: image

varlesh commented 7 years ago

it's emphasize kangoo symbol image

ghost commented 7 years ago

The contrast is too low in my opinion. BTW: That's not the original "w" from the wallabag logo source files or am I wrong?

varlesh commented 7 years ago

Yes, it's not original "w" and others dots too - because i redraw all elements with pixel align. See grid doesn't match with objects. image

ghost commented 7 years ago

Ah I see. Is there a possibility for multiple logos? One with pixel-perfect design and one without it? On most devices today you won't recognize single pixels, on these the original icon could be used :)

varlesh commented 7 years ago

For compare (your icon i'm reduce to 100px, original 200px - my 96px) image

varlesh commented 7 years ago

Pixel align need for clarity

varlesh commented 7 years ago

Ah I see. Is there a possibility for multiple logos? One with pixel-perfect design and one without it? On most devices today you won't recognize single pixels, on these the original icon could be used :)

I'm not have idea how better use original icon with material style...

ghost commented 7 years ago

Then use your pixel-perfect icon 👍

varlesh commented 7 years ago

i'm not want change your main style and logo... your logo very good and stylized. But I create for android app only (on material, how i can)

ghost commented 7 years ago

It's not my logo 😉

varlesh commented 7 years ago

Oh, sorry :) Ok, guys i show some variants for android logo. If you like - please choose colors and tell me sizes for DPI's i'm adapt icons

lokesh-krishna commented 7 years ago

I love the very first icon, before the color merging. I feel like the contrast on that is just right, the kangaroo being subtle enough that it is the “W” that catches the eye but there nevertheless. If somebody can please mention the required DPI then can we proceed with that one itself? And @varlesh Thank you so, so, so, so much! I'm so grateful!

Also, I think a black W on a white circle with a drop shadow for the W would look pretty classy, using the W from the logo source if that's the direction we want to go in. It would be a bit generic though. I still think the first icon is too gorgeous.

lokesh-krishna commented 7 years ago

Sorry about bumping this but isn't this issue something that can be followed up on? Is there anything in particular stalling the discussion?

Strubbl commented 7 years ago

I think finding somebody that follows this issue up as a pull request is stalling this issue.

lokesh-krishna commented 7 years ago

Well, @varlesh said he would provide icons at the requested DPIs and even modify it to meet any changes we suggested. I guess he could file a PR once we told him that or one of you could use the resources and file a PR. What's important is to first confirm which icon we're going ahead with, right?

varlesh commented 7 years ago

2 version: image image

sizes - 24, 32, 48, 64, 96, 128, 192, 256, 512

wallabag.zip

lokesh-krishna commented 7 years ago

I love the second one. Can we have a vote to pick between the two?

tcitworld commented 7 years ago

Yup, please vote here : https://framadate.org/cEbbJS6XahoD8wrw

lokesh-krishna commented 7 years ago

Until when will voting be open? Asking so that we can act upon the choice promptly as without a set time we'll be waiting indefinitely, won't we?

di72nn commented 7 years ago

@varlesh спасибо за работу :-) Can you also make it in 72 and 144 sizes?

tcitworld commented 7 years ago

I find it already clear that the second icon seems to win. :-)

lokesh-krishna commented 7 years ago

@tcitworld Could you also look at #157 before merging this icon? Setting the primary color as #2780e3 with a complementary status bar color would make the app more consistent, wouldn't it? I think the teal used for the toggles too could be colored with the new primary for greater consistency.

tcitworld commented 7 years ago

Yeah, it should be done at the same time.

lokesh-krishna commented 7 years ago

2780e3 isn't a recommended Material Design color though and the closest color to that is #2196f3 as the primary color with #0d47a1 for the status bar. Either could replace teal for the toggles.

varlesh commented 7 years ago

You can modify color what you want:

sed -i 's/#82b4ef/YOUR_COLOR/g' *.svg
sed -i 's/#2780e3/YOUR_COLOR/g' *.svg
lokesh-krishna commented 7 years ago

@varlesh Once again, thank you so much for everything. I was talking about the color scheme that the app would need though, not the icon. The icon is perfect :) @di72nn Can't a SVG be scaled to any size we desire?

lokesh-krishna commented 7 years ago

@Strubbl @di72nn Could one of you take a look at #392 so that this icon can finally make its way to the app?

Strubbl commented 7 years ago

I do not get what the PR #392 is for. And i like the black&white icon. Sorry, i am out

lokesh-krishna commented 7 years ago

Well, @tcitworld agreed that the color scheme would have to be updated to reflect the new icon and this should also be done at the same time so that the icon and the app aren't incongruous.

That's what #392 is about. What I did was edit the theme using the Theme Editor on Android Studio and make a pull request and it turns out that this file is what reflects the change. Is it not the right way to update the color scheme of the app?

Strubbl commented 7 years ago

Thanks @Lokesh-Krishna for clarifying

di72nn commented 7 years ago

@Lokesh-Krishna

Can't a SVG be scaled to any size we desire?

I don't know whether scaling affects pixel alignment. There's probably a reason why it's not just uploaded in 512 only.

lokesh-krishna commented 7 years ago

@di72nn You're absolutely right. Turns out that using a single size results in blurring because of the pixel alignment.

@varlesh Could you please provide the icons at 72px and 144px as well?

varlesh commented 7 years ago

wallabag-logo-material-svgs.tar.gz

lokesh-krishna commented 7 years ago

So we have everything we need now? How would one go about making a pull request for this?