entrypoint: enable configuring PHP memory limit

wallabag / docker

Official docker-composer for wallabag.

594 stars 150 forks source link

entrypoint: enable configuring PHP memory limit #374

Closed Maffsie closed 6 months ago

Maffsie commented 1 year ago

Adds an environment variable, PHP_MEMORY_LIMIT, which overrides the default memory limit as shipped by PHP.

This environment variable, if specified, should be in the format normally expected by PHP (such as 256M or 1G). If unspecified, it defaults to the memory limit specified in php.ini at time of writing, which is 128M. If desired, a more specific default value can be chosen.

Supercedes https://github.com/wallabag/docker/pull/125 Supercedes https://github.com/wallabag/docker/pull/166 Closes https://github.com/wallabag/docker/issues/124

Maffsie commented 1 year ago

@j0k3r Added documentation to the README; sorry I didn't notice it should be there!

pparidans commented 1 year ago

Hi, first off :+1: for this change (that actually would allow me to re-fetch some of my entries as they systematically blow the memory limit up).

Naive question but, any update on merging this PR ?

akosiaris commented 7 months ago

Coming from #400 (thanks @j0k3r for pointing me here, I had missed this PR) where I followed a similar, albeit less developed approach, I wanna ask if I can help somehow push this forward. I see it's lingering for a few months now.

Kdecherf commented 6 months ago

Hello @Maffsie,

I've opened #403 which is based on envsubst and does not edit the base php.ini file

Kdecherf commented 6 months ago

Superseded by #403