search

wallabag / wallabagger

Chrome / Firefox / Opera plugin for wallabag v2.
http://wallabag.github.io/wallabagger/
MIT License
365 stars 47 forks source link

Fetch content directly from the browser for each website #309

Closed nicosomb closed 1 year ago

nicosomb commented 2 years ago

Hi there!

Thank you so much @agallou for your work.

Is that possible to remove the configuration part of your work and fetch content directly from the browser for each website?

Nicolas

agallou commented 2 years ago

In my mind this would be a BC break (the configuration were here to opt-in on this functionality).

Some behaviors would break. For example : if I'm on mediapart (supported with the site credentials, and configured on my account), but not connected, currently I can add it to wallabag with the extension and the full article will be on Wallabag, available to read it later.

If we remove the configuration part, this will stop working.

Do you still want to remove the configuration part ? (if that's the case I can prepare a pull request for that).

nicosomb commented 2 years ago

One point for the credentials part.

lapineige commented 2 years ago

Would it be possible to use Wallabag API to check if some credentials exist for a particular website/domain, and if not then directly retrieve browser content ?

nicosomb commented 2 years ago

@lapineige I also thought about this solution. But we need to work on wallabag API.

Kdecherf commented 2 years ago

Another way I would approach it is to add an action in this extension's menu to save the article by grabbing the content:

2022-03-21-130537_2560x1440

Kdecherf commented 2 years ago

(I'm not a big fan of making the extension always grab the content by removing the configuration btw, however we could put an opt-in configuration to do that)

lapineige commented 2 years ago

Another way I would approach it is to add an action in this extension's menu to save the article by grabbing the content:

Well if that is possible, I think that's the best way to do it, that's easier and as fast to do for both use case.

biva commented 2 years ago

Definitely! It would make it really usable by everybody because adding a line in the config is not easy for everyone. Congrats again for this feature!! Does it represent a lot of work? Happy to test if needed

Kdecherf commented 1 year ago

Can we consider this as a satisfying fix or workaround @nicosomb?

https://kdecherf.com/blog/2023/08/02/fetch-content-from-browser-on-demand-with-wallabagger/