wallabyjs / atom-wallaby

Wallaby.js atom package starter
Other
57 stars 6 forks source link

Deprecated selector in `atom-wallaby\styles\wallaby.atom-text-editor.less` #55

Closed ummahusla closed 7 years ago

ummahusla commented 7 years ago

In atom-wallaby\styles\wallaby.atom-text-editor.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

ummahusla commented 7 years ago

After a quick research, I found the fix in #53 which hasn't been merged yet.

ArtemGovorov commented 7 years ago

Yep, will merge it later. It shouldn't break anyway even when it's deprecated, because there's a correct style in place as well.

ummahusla commented 7 years ago

@ArtemGovorov Okay, thanks 👍

prashanfdo commented 7 years ago

Atom has disabled the package since its deprecated.

ArtemGovorov commented 7 years ago

@Prashanfdo What version of Atom is it?

prashanfdo commented 7 years ago

Version 1.16.0 on Windows 10

prashanfdo commented 7 years ago

image

ArtemGovorov commented 7 years ago

@Prashanfdo Try updating wallaby package to the latest, we have fixed it.

prashanfdo commented 7 years ago

Updated to 1.0.17 No deprecation now. Super 👍