search

wallabyjs / atom-wallaby

Wallaby.js atom package starter
Other
57 stars 6 forks source link

There should be some sort of indication when there is a compile error #7

Closed aaronjensen closed 9 years ago

aaronjensen commented 9 years ago

Right now, if you have a compiler error, it outputs to the console, but if you don't have that open, wallaby just looks like it is spinning forever.

ArtemGovorov commented 9 years ago

@aaronjensen Does it happen with Babel compiler errors? I have tried a few errors, but all of them make the indicator red. Am I reproducing the issue correctly and if so, could you please paste a sample error that makes the indicator to spin forever (until fixed)? i

aaronjensen commented 9 years ago

Not at a computer, but if I remember correctly , it was an error in my webpack config which was required by my wallaby conf 

Aaron

On Sun, Sep 6, 2015 at 6:35 PM, Artem Govorov notifications@github.com wrote:

@aaronjensen Does it happen with Babel compiler errors? I have tried a few errors, but all of them make the indicator red. Am I reproducing the issue correctly and if so, could you please paste a sample error that makes the indicator to spin forever (until fixed)?

i

Reply to this email directly or view it on GitHub: https://github.com/wallabyjs/atom-wallaby/issues/7#issuecomment-138153289

ArtemGovorov commented 9 years ago

Still no luck reproducing it yet, here is what I do now: making a syntax error in webpack config file (which is required from wallaby config), saving it, re-running wallaby. Seems to work as expected: i

aaronjensen commented 9 years ago

I can't reproduce this anymore, it seems to work as expected now. I'll re-open if I see it again. Thanks!