search

wallabyjs / ngCliWebpackSample

68 stars 48 forks source link

tsconfig.spec.json is not complete by itself #12

Closed victornoel closed 7 years ago

victornoel commented 7 years ago

Hi,

I noticed that ./src/tsconfig.spec.json refers to ./tsconfig.json, so normally, to be complete, we should be doing something like that in wallaby.js:

var compilerOptions = require('./tsconfig.json').compilerOptions;
Object.assign(compilerOptions, requir('./src/tsconfig.spec.json').compilerOptions);

(except maybe for the baseUrl property that may be wrong in that case…)

What do you think?

ArtemGovorov commented 7 years ago

Makes perfect sense, I have changed wallaby config as per your suggestion.