wallabyjs / public

Repository for Wallaby.js questions and issues
http://wallabyjs.com
760 stars 45 forks source link

Wallaby UI elements not showing up in VSCode (e.g. code coverage indicators, footer test icon, etc.) #1070

Closed cdavis1324 closed 7 years ago

cdavis1324 commented 7 years ago

Issue description or question

Wallaby UI elements are not showing up in VSCode (e.g. code coverage indicators, footer test icon, etc.). I can see in the VScode wallaby output that the tests are in fact running, but I just see no indication that they are in the vscode IDE.

I can also successfully navigate to the test overview page to verify that the tests are running as well.

image

Wallaby.js configuration file

module.exports = function wallabyConfig(wallaby) {
  return {
    files: [
      'lib/use-extender/*.js',
      'modules/**/*.js',
      'plugins/**/*.js'
    ],

    tests: [
      'test/lib/*test.js'
    ],
    env: {
      type: 'node'
    }
  };
};

Code editor or IDE name and version

Visual Studio Code v1.10.2 (1.10.2)

OS name and version

OSX 10.12.3

ArtemGovorov commented 7 years ago

Could you please:

cdavis1324 commented 7 years ago

Hi Artem,

I've verified that:

image

image

Here is a list of the current VSCode Extensions I have installed:

I've started to systemically disable some of these in order to identify whether any of them are causing the problem.

ArtemGovorov commented 7 years ago

Could you please try downloading the insiders build, installing wallaby and trying to run it? If you don't have it installed, there'll be no extensions there, so may be a good isolated test.

ArtemGovorov commented 7 years ago

footer test icon

Also, what do you mean by the footer test icon? I thought you mean the status bar indicator, but it looks like it's there from your screenshot: 534ac128-0ce7-11e7-92f7-8494c0080856

cdavis1324 commented 7 years ago

Hey Artem,

My mistake on the footer. I was used to seeing it on the other side (it's been a while since I've used Wallaby in a project). So, it seems that the issue is just that the code coverage indicators aren't showing.

Everything works with the installer build. So, it seems that the issue exists with one of the extensions I have installed. I'll try uninstalling what I have in order to isolate what the offending Extension is.

Thanks for your help!

cdavis1324 commented 7 years ago

So, I've just uninstalled every extension I have except for Wallaby and Quokka and the issue still remains :(

image

Do you have any other suggestions that I should try?

Thanks

ArtemGovorov commented 7 years ago

Interesting, I have installed all of the extensions and can't reproduce the issue (same OS). Perhaps it's some extension setting, or general settings that are different. Try pasting your settings.json to the insiders build to see if it breaks wallaby there. Also try uninstalling Quokka.js.

cdavis1324 commented 7 years ago

I fixed it!

I copied over the default settings.json user settings file from the insiders build and that did the trick.

So, it seems I had a bad setting in my settings.json file which was causing the problem. I'm going to do a bit more digging and try to find out what the exact setting that was causing the issue is.

Thanks again for all your help.

ArtemGovorov commented 7 years ago

@Wallysburg Awesome, thanks for the update! It'd be really great if you could find the setting - I'd document it so that other users could avoid hitting the same issue.

cdavis1324 commented 7 years ago

@ArtemGovorov

Here's the problematic setting: "editor.glyphMargin": false

When "editor.glyphMargin": true it works fine.

Give the name of this setting, this feels obvious in hindsight. However, I don't remember ever explicitly setting this property to false, so perhaps it was set during a vscode update or something? Anyway, hopefully this information will be beneficial to anyone else that experiences this issue in the future.

Thanks again.

ArtemGovorov commented 7 years ago

Awesome, thanks a lot! I was planning to mention it in our docs, but have a better idea - we'll read the setting from the extension and if the setting's value is set to false, then wallaby will notify the user about the implications.

michael-letcher commented 5 years ago

2111 solution is here for anyone who maybe having this issue now.