Closed whindes closed 7 years ago
First of all, you need to remove the dot from the extension, as in the example here.
extensions: {
javascript: ['ejs']
},
It'll still not work unfortunately, because of some restrictions in Visual Studio extension model. We have found the solution and are working on it, I'll let you know as soon as the new extension version is available.
Could you please also clarify something for us - are you using any VS extension to get the syntax highlighting in .ejs
files?
Good morning from Seattle!
Some of these may have been installed by a bundled VSIX (Web Essentials..??)
All of these below are from the same Creator: Mads Kristensen
Markdown Editor
Editor Enhancements EditorConfig Language Service HTML Snippet Pack HTML Tools Syntax Highlighting Pack
At one time before using Visual Studio 2017 (using VS 2015), I had just used the Tools>Options>Text Editor>File Extension and added .ejs Now, there is nothing configured there at this time.
Ok, we have done some investigation, and it looks like we don't need to release any updates. It should work for you if you:
extensions: {
javascript: ['ejs']
},
.ejs
file with JavaScript editor in your VS settings:Let us know if it works for you this way.
I tried this in both Visual Studio 2015 & Visual Studio 2017... no success.
@whindes Sorry about it, I confirm - we have found the scenarios when it doesn't work, we are investigating it further.
Ok, so we have released the new 1.0.32 version of the extension. Please restart your VS to get the update prompt (or install the latest from our website), and try it.
Updated to 1.0.32.... (says aleady updated) restarted vs 2017 wallaby.js started core v1.0.416 (same core?)
No change.
Could you please attach your current wallaby config and the full list of VS extensions that you currently have installed?
Also, just in case if it is a caching issue, try changing your wallaby config (even a space anywhere in the file is enough) and restarting wallaby.
One more thing, could you please also attach a screenshot of the .ejs
file where it doesn't show the indicators and the screenshot of the installed wallaby extension page (from Tools - Extensions...
)?
module.exports = function () {
return {
extensions: {
javascript: ['ejs']
},
setup: function () {
require.extensions['.ejs'] = require.extensions['.js'];
},
files: [
'managers/**/*.js',
'services/**/*.js',
{ pattern: 'views/angularjs/*.ejs', instrument: true }
],
tests: [
'test/*.js'
],
env: {
type: 'node',
runner: 'node' // or full path to any node executable
}
};
};
Installed Visual Studio Extensions .ignore Add New File Azure Data Lake Tools for Visual Studio Bootstrap Snippet Pack Browser Reload on Save Browser Sync Bundler & Minifier Css Tools Developer Analytics Tools Editor Enhancements EditorConfig Language Service Extensibility Tools File Icons File Nesting HTML Snippet Pack HTML Tools Image Optimizer Image Sprites Javascript Regions JavaScript Snippet Pack JavaScript Transpiler Markdown Editor Microsoft Advertising SDK for Windows 8.1 Microsoft Advertising SDK for Phone Microsoft ASP.NET and Web Tools Microsoft Azure App Service Tools Microsoft Office 365 API Tools Microsoft Visual Studio Test Platform Microsoft Visual Studio Tools for Containers Microsoft VisualStudio Managed Publish Microsoft.VisualStudio.UniversalLibrary.dll MSTest V2 Create Unit Test Extension MSTest V2 Templates MSTest V2 Templates (Universal Windows) Node.js Tools Node.js Tools - Interactive Window NPM Task Runner Open Command Line Package Installer Package Security Alerts PowerShell Tools for Visual Studio 2017 Project File Tools Razor Language Services ReSharper Ultimate Rosyln Expression Evaluators Roslyn Interactove Components Roslyn Language Services Roslyn Language Services for Visual Studio 15 Serice Fabric Tools SQL Search Syntax Highlighting Pack TypeScript for Microsoft Visual Studio Visual F# Tools Visual Studio Extensibility Templates Visual Studio Extension for TextMate Grammers Visual Studio Extensions for Windows Library VisualStudio Interactive WIndow Vue.js Pack 2017 Wallaby.js for Visual Studio 2017 Web Accessibilty Checker Web Compiler Web Essensials 2017 ZenCoding
Thanks, try resetting wallaby cache, I think it should help.
Reset Cache (Change wallaby.js line)" 'views/angularjs/*.ejs',
Reset and restart VS 2017 no luck. I even removed the Githubissues.
Issue description or question
We should be able to see code coverage lines in the configured .ejs extension.
Only when renaming the file in the view folder (views/angularjs/*.ejs) to .js extention it lights up the code coverage lines correctly. Expecting the same behavior with .ejs configured in wallaby.js
Mocha is working for both .ejs and .js scenarios above.
Thanks in advance for enhancing this feature.
Cheers!
Wallaby.js configuration file
Code editor or IDE name and version
Visual Studio 2017
OS name and version
Windows 10