Closed tslocke closed 9 months ago
I've just noticed that the test decorations, e.g. "focus", are not showing.
This can be expected sometimes (for example, if a test does not run at all). There are also VS Code settings that you may like to double check:
From past experience I believe this means other bad things are probably happening 🫤
We tried using your dependencies, Vite, and Wallaby configuration and everything appears to be working for us. But it may be related to your tests themselves.
My tests seem to be running very slowly and I'm getting stuck node processes.
Are they running slowly only in Wallaby? You should be able to check using time npx vitest --run
to run your tests from the command-line.
I thought I'd use git bisect to figure out where the problem started, but every old commit I check out has the same problem, even going back months. I'm sure the problem wasn't there back then.
Are you able to provide us with a sample that has the same problem? If you're able, you could also try an older Wallaby version by following our offline installation instructions. This may help isolate if it's a Wallaby-related issue.
This can be expected sometimes (for example, if a test does not run at all)
I assume this means that when I was testing old commits, I should have been running the tests before concluding there was a problem, which I did not originally do, so my conclusion that the problem is not in my code is probably wrong.
I assume this means that when I was testing old commits, I should have been running the tests before concluding there was a problem, which I did not originally do, so my conclusion that the problem is not in my code is probably wrong.
I'm not entirely clear on what you did to test your old commits. If you were reverting to previous commits, you would definitely want to reinstall your packages and restart Wallaby each time you made a change to make sure Wallaby was using the old dependencies and configuration.
Have found some time to look into this and am working on a proper repro for you.
Quick question - is it expected that if I have a .only on a test, the decorations won't show at all, including on the one test that runs? (that's what I'm seeing)
OK I managed to create a very minimal repro that's showing one of the various problems I'm having. It's a different issue so I'll open a new ticket.
Actually it's an old one that's shown up again - I found the old ticket so I'll re-open that one (#3165)
UPDATE: Turns out I don't get to re-open the ticket so that one is still closed, but it has the repro info in a new comment.
It looks like part of the problem might be an error in your exception handling code (or is it in vitest? I'm not sure). I ended up hacking around in the vscode extensions directory to fix this:
In runners/node/vitest@0.14.0/shared.mjs I found (this is minimised of course):
s.log.push(e.setAssertionData(err, { message: "Test never executed, likely due to an uncaught exception", passed: !1 }))
That err
is not in scope. I changed it to {}
. I think that has helped but I'm still tracing other problems.
OK this got weird. After fixing that err is undefined
error, I started seeing 'Test never executed, likely due to an uncaught exception' in the Wallaby Tests panel. I removed... well everything 😁, and I'm still seeing it.
It happens when one test has a .only and one doesn't.
No problems running this via vitest on the command line.
Repo: https://github.com/tslocke/wallaby-issue-2023.11-uncaught-exception
This is the same problem as: https://github.com/wallabyjs/public/issues/3165
I've just noticed that the test decorations, e.g. "focus", are not showing. From past experience I believe this means other bad things are probably happening 🫤 My tests seem to be running very slowly and I'm getting stuck node processes.
I thought I'd use git bisect to figure out where the problem started, but every old commit I check out has the same problem, even going back months. I'm sure the problem wasn't there back then.
So I'm wondering what could cause that problem that's not tracked by git. I've tried forcing a core update, and reinstalling Wallby.
Anything else I can try? Thanks : )