wallabyjs / public

Repository for Wallaby.js questions and issues
http://wallabyjs.com
759 stars 45 forks source link

[TypeScript, Jest] - Wallaby stopped working suddenly (ostensibly after Jest 16 update) #828

Closed dsifford closed 8 years ago

dsifford commented 8 years ago

Issue description or question

Hi there. I recently noticed that wallaby stopped working at some point in the last 7-14 days in one of my repos. I'm not sure if there were changes in the wallaby config API or if Jest 16 screwed something up (from looking at other issues it looks like the latter is not the case).

Here's the repo if you'd like to see what I have going on: https://github.com/dsifford/academic-bloggers-toolkit

Wallaby.js configuration file

module.exports = {
    files: [
        'src/**/*.{tsx,ts}',
        'types/**/*.d.ts',
        './package.json',
        {
            pattern: 'scripts/*.js',
            instrument: false,
        },
        '!src/lib/js/utils/Externals.ts',
        '!src/**/__tests__/*',
        '!src/**/index.{ts,tsx}',
        '!src/lib/js/Frontend.ts',
        '!src/lib/js/utils/TinymceFunctions.ts',
    ],
    tests: [
        'src/**/__tests__/*-test.{ts,tsx}',
    ],
    env: {
        type: 'node',
        runner: 'node',
    },
    testFramework: 'jest',
    setup(wallaby) {
        wallaby.testFramework.configure(require('./package.json').jest); // eslint-disable-line
    },
};

Code editor or IDE name and version

Atom...

$ atom --version
Atom    : 1.10.2
Electron: 0.37.8
Chrome  : 49.0.2623.75
Node    : 5.10.0

OS name and version

Arch Linux


Thanks so much in advance for the help. πŸ˜„

ArtemGovorov commented 8 years ago

I have sent you 2 PRs: https://github.com/dsifford/academic-bloggers-toolkit/pull/190 and https://github.com/dsifford/academic-bloggers-toolkit/pull/191. For some reason some source files were excluded in your wallaby config, causing module not find errors. After removing the exclusions, I found another issue with

jest.unmock('../ReferenceList.tsx');
jest.unmock('../../Store.ts');

Using file extensions is not required and breaks wallaby jest integration (you're not using file extensions anywhere else anyway).

P.S. I have also seen a transient issue with API tests (something about bad network request), but the issue shows up when running jest from CLI.

dsifford commented 8 years ago

@ArtemGovorov Wow thanks so much! You went above and beyond, as usual πŸ˜„

Good to know Re: file extensions issue. Those unmocks were probably added using code completion or something because I've never added extensions purposefully!

Thanks again!

dsifford commented 8 years ago

Actually -- I'm working on a feature branch which is a bit different than the master branch right now. I made the necessary changes to that feature branch described in the pull requests and it's still saying 0 failing tests, 0 passing in the panel in atom.

Any ideas?

Here's that branch: https://github.com/dsifford/academic-bloggers-toolkit/tree/next

(I'm pushing the changes now so the branch will be caught up to this exact moment on github).

Thanks so much.

ArtemGovorov commented 8 years ago

Got the branch, did npm install and everything seems to be working for me (0 failing tests, 144 passing):

screen shot 2016-10-15 at 10 00 23 am
dsifford commented 8 years ago

Super strange! Possibly a conflict with another package?

Here's my list:

Community Packages (79) /home/dsifford/.atom/packages
β”œβ”€β”€ Stylus@3.1.0
β”œβ”€β”€ Sublime-Style-Column-Selection@1.7.2
β”œβ”€β”€ advanced-open-file@0.16.4
β”œβ”€β”€ atom-alignment@0.12.1
β”œβ”€β”€ atom-beautify@0.29.13
β”œβ”€β”€ atom-typescript@10.1.9
β”œβ”€β”€ atom-wallaby@1.0.11
β”œβ”€β”€ autocomplete-clang@0.10.0
β”œβ”€β”€ autocomplete-go@1.3.0
β”œβ”€β”€ autocomplete-paths@1.0.2
β”œβ”€β”€ builder-go@1.0.1
β”œβ”€β”€ code-peek@1.4.11
β”œβ”€β”€ docblockr@0.8.7
β”œβ”€β”€ editorconfig@1.4.1
β”œβ”€β”€ emmet@2.4.3
β”œβ”€β”€ environment@1.2.0
β”œβ”€β”€ exception-reporting@0.40.0
β”œβ”€β”€ git-time-machine@1.5.3
β”œβ”€β”€ go-config@1.2.4
β”œβ”€β”€ go-debug@0.1.22
β”œβ”€β”€ go-get@2.1.1
β”œβ”€β”€ go-plus@4.3.2
β”œβ”€β”€ godoc@1.1.1
β”œβ”€β”€ gofmt@1.2.0
β”œβ”€β”€ gometalinter-linter@1.2.2
β”œβ”€β”€ gorename@1.1.0
β”œβ”€β”€ gpp-compiler@3.0.7
β”œβ”€β”€ highlight-selected@0.11.2
β”œβ”€β”€ hyperclick@0.0.39
β”œβ”€β”€ hyperclick-php@0.2.1
β”œβ”€β”€ increment-me@0.4.1
β”œβ”€β”€ js-hyperclick@1.9.0
β”œβ”€β”€ language-babel@2.44.1
β”œβ”€β”€ language-docker@1.1.7
β”œβ”€β”€ language-jade@0.7.2
β”œβ”€β”€ language-nginx@0.6.2
β”œβ”€β”€ language-rust@0.4.7
β”œβ”€β”€ linter@1.11.18
β”œβ”€β”€ linter-clang@3.4.4
β”œβ”€β”€ linter-eslint@8.0.0
β”œβ”€β”€ linter-golinter@1.2.1
β”œβ”€β”€ linter-js-yaml@1.2.5
β”œβ”€β”€ linter-jsonlint@1.3.0
β”œβ”€β”€ linter-php@1.3.1
β”œβ”€β”€ linter-phpmd@1.5.2
β”œβ”€β”€ linter-pylama@0.7.6
β”œβ”€β”€ linter-rust@0.6.0
β”œβ”€β”€ linter-shellcheck@1.4.1
β”œβ”€β”€ linter-stylint@2.2.5
β”œβ”€β”€ linter-tslint@0.11.1
β”œβ”€β”€ markdown-scroll-sync@2.1.2
β”œβ”€β”€ merge-conflicts@1.4.4
β”œβ”€β”€ metrics@1.0.0
β”œβ”€β”€ minimap@4.25.0
β”œβ”€β”€ minimap-bookmarks@0.4.2
β”œβ”€β”€ minimap-cursorline@0.2.0
β”œβ”€β”€ minimap-git-diff@4.3.1
β”œβ”€β”€ minimap-highlight-selected@4.4.0
β”œβ”€β”€ minimap-linter@1.6.0
β”œβ”€β”€ minimap-split-diff@0.3.2
β”œβ”€β”€ navigator-go@1.1.3
β”œβ”€β”€ nerd-treeview@0.4.2
β”œβ”€β”€ package-sync@1.1.0
β”œβ”€β”€ pdf-view@0.50.0
β”œβ”€β”€ pigments@0.37.0
β”œβ”€β”€ project-plus@0.9.0
β”œβ”€β”€ qolor@0.4.0
β”œβ”€β”€ racer@0.20.0
β”œβ”€β”€ script@3.10.1
β”œβ”€β”€ set-syntax@0.3.2
β”œβ”€β”€ sort-lines@0.14.0
β”œβ”€β”€ split-diff@1.0.5
β”œβ”€β”€ sync-settings@0.7.2
β”œβ”€β”€ tester-go@2.0.2
β”œβ”€β”€ todo@0.6.0
β”œβ”€β”€ tree-view-autoresize@1.2.0
β”œβ”€β”€ turbo-javascript@1.4.0
β”œβ”€β”€ vim-mode-plus@0.60.0
└── vim-mode-plus-move-selected-text@0.6.1
ArtemGovorov commented 8 years ago

It's very unlikely, the issue seems to be in the core, not the editor integration. Is wallaby.js in the master branch currently working for you? Try doing a clean npm install in the next branch, perhaps there's some issue with installed packages. if it doesn't help, try setting debug: true and paste the output from the Wallaby Console in Atom dev tools.

dsifford commented 8 years ago

Will do. Thanks so much again. Seriously, can't stress how grateful I am for your help.

Give me a few and I'll report back.

dsifford commented 8 years ago

@ArtemGovorov Sorry for the delay. Still no luck after a clean install of my node modules.

There's thousands and thousands of lines of debug messages, but I think these are probably the one's you'll be interested in:

Wallaby Console: Sat, 15 Oct 2016 01:24:30 GMT wallaby:nodeRunner Preparing sandbox [worker #5, session #tl2md]
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:30 GMT wallaby:workers Starting run worker instance #5
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:31 GMT wallaby:nodeRunner Error in worker: Error: Cannot find module 'Q'
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Function.Module._resolveFilename (module.js:440:15)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Function.Module._load (module.js:388:25)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.require (module.js:468:17)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.s.require (/home/dsifford/.atom/packages/atom-wallaby/wallaby/server.js:18:27449)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at require (internal/module.js:20:19)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Object.<anonymous> (/home/dsifford/.atom/packages/atom-wallaby/wallaby/runners/node/jest@0.4.3/initializer.js:14:54)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module._compile (module.js:541:32)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Object.Module._extensions..js (module.js:550:10)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.load (module.js:458:32)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at tryModuleLoad (module.js:417:12)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:31 GMT wallaby:nodeRunner Error in worker: Error: Cannot find module 'Q'
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Function.Module._resolveFilename (module.js:440:15)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Function.Module._load (module.js:388:25)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.require (module.js:468:17)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.s.require (/home/dsifford/.atom/packages/atom-wallaby/wallaby/server.js:18:27449)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at require (internal/module.js:20:19)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Object.<anonymous> (/home/dsifford/.atom/packages/atom-wallaby/wallaby/runners/node/jest@0.4.3/initializer.js:14:54)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module._compile (module.js:541:32)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Object.Module._extensions..js (module.js:550:10)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.load (module.js:458:32)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at tryModuleLoad (module.js:417:12)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:31 GMT wallaby:nodeRunner Error in worker: Error: Cannot find module 'Q'
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Function.Module._resolveFilename (module.js:440:15)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Function.Module._load (module.js:388:25)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.require (module.js:468:17)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.s.require (/home/dsifford/.atom/packages/atom-wallaby/wallaby/server.js:18:27449)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at require (internal/module.js:20:19)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Object.<anonymous> (/home/dsifford/.atom/packages/atom-wallaby/wallaby/runners/node/jest@0.4.3/initializer.js:14:54)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module._compile (module.js:541:32)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Object.Module._extensions..js (module.js:550:10)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.load (module.js:458:32)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at tryModuleLoad (module.js:417:12)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:31 GMT wallaby:nodeRunner Error in worker: Error: Cannot find module 'Q'
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Function.Module._resolveFilename (module.js:440:15)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Function.Module._load (module.js:388:25)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.require (module.js:468:17)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.s.require (/home/dsifford/.atom/packages/atom-wallaby/wallaby/server.js:18:27449)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at require (internal/module.js:20:19)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Object.<anonymous> (/home/dsifford/.atom/packages/atom-wallaby/wallaby/runners/node/jest@0.4.3/initializer.js:14:54)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module._compile (module.js:541:32)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Object.Module._extensions..js (module.js:550:10)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.load (module.js:458:32)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at tryModuleLoad (module.js:417:12)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:31 GMT wallaby:nodeRunner Error in worker: Error: Cannot find module 'Q'
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Function.Module._resolveFilename (module.js:440:15)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Function.Module._load (module.js:388:25)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.require (module.js:468:17)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.s.require (/home/dsifford/.atom/packages/atom-wallaby/wallaby/server.js:18:27449)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at require (internal/module.js:20:19)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Object.<anonymous> (/home/dsifford/.atom/packages/atom-wallaby/wallaby/runners/node/jest@0.4.3/initializer.js:14:54)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module._compile (module.js:541:32)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Object.Module._extensions..js (module.js:550:10)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.load (module.js:458:32)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at tryModuleLoad (module.js:417:12)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:31 GMT wallaby:nodeRunner Error in worker: Error: Cannot find module 'Q'
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Function.Module._resolveFilename (module.js:440:15)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Function.Module._load (module.js:388:25)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.require (module.js:468:17)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.s.require (/home/dsifford/.atom/packages/atom-wallaby/wallaby/server.js:18:27449)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at require (internal/module.js:20:19)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Object.<anonymous> (/home/dsifford/.atom/packages/atom-wallaby/wallaby/runners/node/jest@0.4.3/initializer.js:14:54)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module._compile (module.js:541:32)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Object.Module._extensions..js (module.js:550:10)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at Module.load (module.js:458:32)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console:     at tryModuleLoad (module.js:417:12)
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:40 GMT wallaby:workers Worker is not created in time, recycling it
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:40 GMT wallaby:project Test run cancelled, re-queueing run data
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:40 GMT wallaby:project Test run finished
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:40 GMT wallaby:project Test run data re-queued
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:40 GMT wallaby:project Running postprocessor
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:40 GMT wallaby:postprocessor TypeScript language service re-created because some tracked files were added or deleted
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/Frontend.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/components/Spinner.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/components/ToggleSwitch.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/reference-list/API.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/reference-list/Store.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/reference-list/components/Card.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/reference-list/components/ItemList.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/reference-list/components/Menu.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/reference-list/components/PanelButton.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/reference-list/components/ReferenceList.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/reference-list/index.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/tinymce/components/import-window/ImportWindow.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/tinymce/components/import-window/index.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/tinymce/components/pubmed-window/Paginate.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/tinymce/components/pubmed-window/PubmedWindow.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/tinymce/components/pubmed-window/ResultList.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/tinymce/components/pubmed-window/index.js
/home/dsifford/.atom/packages/atom-wallaby/wallaby-atom/index.js:14 Wallaby Console: Sat, 15 Oct 2016 01:24:41 GMT wallaby:project Preparing to process src/lib/js/tinymce/components/reference-window/components/Butto

Let me know if there's anything else I might be able to help with.

ArtemGovorov commented 8 years ago

@dsifford Awesome, thanks for the log, it's very helpful. I believe I fixed the issue in core v1.0.306. You may wait for an automatic update or force the update. Please let me know if it fixes the issue for you.

dsifford commented 8 years ago

@ArtemGovorov Sorry for the delay. Yep, the issue is all fixed!

I noticed a completely different issue now though related to coverage reporting. Let me know if you'd like me to create a separate issue and I will.

In the meantime: The gist of the issue is, instrument: false isn't working. Coverage for the files is still being reported in wallabyjs.com/app

ArtemGovorov commented 8 years ago

@dsifford Awesome, thanks for checking. Yes, please create a new issue for the coverage problem, share the repo (if it's different from the one in this issue), the branch to look at and the file with instrument: false and reported coverage.