wallabyjs / quokka

Repository for Quokka.js questions and issues
https://quokkajs.com
1.18k stars 31 forks source link

Atom: quokka-panel not respecting cmd-± #85

Open metasean opened 7 years ago

metasean commented 7 years ago

Issue description

Click inside the "Quokka" panel. ⌘⎻+ should increase the font size, but does not ⌘⎻﹣ should decrease the font size, but does not

Quokka.js file

any

Quokka.js Console Output

any console output visible in the .quokka-panel-view / .quokka-results-view

Code editor version

Atom 1.19.3

OS name and version

OSX Sierra 10.12.3

Tried - Does not work

Since this is clearly a keybinding-related issue, I tried adding the following to my keymap.cson file, but it didn't have any effect.

'.platform-darwin .quokka-results-view':
 'cmd--': 'window:decrease-font-size'
  'cmd-+': 'window:increase-font-size'

Interestingly, I have several plug-ins that add panels, some require an additional keymap, and some don't.

Stop-gap work-around for end users

In your Atom stylesheet, "styles.less", add:

.quokka-results-view {
  font-size: 120%; // modify value as appropriate
}
ArtemGovorov commented 7 years ago

I wasn't aware that cmd-+ should control panel font size. Doesn't seem to be respected in any Atom built-in packages. For example, if I open a project's Tree View and try the shortcut there, it doesn't work. Or If I open Time Cop View or Settings View - the shortcut doesn't work there either.