wallabyjs / quokka

Repository for Quokka.js questions and issues
https://quokkajs.com
1.18k stars 31 forks source link

`show-value-on-selection` not working #887

Closed janniks closed 1 year ago

janniks commented 1 year ago

Issue description or question

Is this issue related to Quokka not outputting the expected results of your code?: No

https://quokkajs.com/docs/configuration.html#show-value-on-selection show-value-on-selection hasn't been working for a while for me.

I don't use any configuration files or custom settings for Quokka. This used to work (last time I can remember maybe 3-5months ago, but lately it never works)

Code editor version

Visual Studio Code Version: 1.81.1

OS name and version

macOS 13.4.1

ArtemGovorov commented 1 year ago

Hello, thanks for bringing the outdated docs section to our attention.

Few weeks ago we have changed the setting's default to be false at the same time when we have released Logpoints feature:

Change to Default Settings: Please note that the default value of the Show Value on Selection setting has been changed from true to false. This adjustment reflects our belief that users will prefer the new Logpoints feature, and those who wish to continue using this feature alongside or instead of Logpoints may re-enable it.

If you prefer to use the previous behaviour instead of the new one, you may add the setting in your Global Quokka config file:

{
   ...
+  "showValueOnSelection": true
}

We have also updated the referenced docs section to reflect the changed default setting value.

janniks commented 1 year ago

Awesome, thanks for this πŸ‘ Sorry I missed it -- Did you just update the docs (for the default), or am I going crazy? πŸ˜…

smcenlly commented 1 year ago

Yes, we updated the docs about 2 minutes after you raised the issue ☺️.