search

wallaceEcoMod / wallace

an interactive, reproducible, expandible, instructional, and open-source GUI-based app for ecological niche modeling
https://wallaceecomod.github.io/
GNU General Public License v3.0
132 stars 46 forks source link

fixes as requested by cory/gonzalo #355

Closed daattali closed 3 years ago

gepinillab commented 3 years ago

Hi Dean (cc @cmerow),

Thanks for all the fixes. The new close button and the scrollbar are working without problems.

The only thing that is not working is the disable_module() function. There was a typo in the module argument in modules/userEnvs.R#103. After changing it to the correct module name, it is still not working. common$disable_module(component = "proj", module = "proj_time")

I also checked the remove_module() before your pull request, which is not working either.

Please let me know if you need some info to solve this issue.

Best, Gonzalo

daattali commented 3 years ago

I just tried the following and it worked:

To ui.R I added actionButton("test", "test")

To server.R I added observeEvent(input$test, common$disable_module("proj", "time"))

gepinillab commented 3 years ago

Dean,

Thanks for the clarification. It worked. I also did some testing with the enable_module(). Everything is working without problems.

Is it possible to add personalized text instead of the disable icon when placing the mouse cursor in a disable module? Is this something that you can include as an argument in disable_module()?

Gonzalo

daattali commented 3 years ago

It is possible, but it's not a quick 10 minute thing to add, it'll require some time to research the best way, try out different implementations, and test.

gepinillab commented 3 years ago

Okay, no problem. Maybe it will be something to add in the future.

Thanks again for all the fixes!