search

walle / gimli

Utility for converting markup files to pdf files
https://github.com/walle/gimli
MIT License
538 stars 44 forks source link

Properly handle smart quotes from Textile. #30

Closed kaukas closed 5 years ago

kaukas commented 12 years ago

Hello.

I had problems getting the Textile-generated smart quotes through to pdf. The reason turned out to be the usage of utf-8 encoding and Nokogiri XML document parser. I switched to ASCII-8BIT and HTML and got the desired functionality without breaking the tests.

Please see the explanation here: http://stackoverflow.com/questions/4476047/how-to-make-nokogiri-not-to-convert-nbsp-to-space

This is a big change so I understand that you may want to clean it up or test more or even reject the request. Please feel free to contact me if any more help needed though.

A (now working) testcase added.

travisbot commented 12 years ago

This pull request fails (merged 28d8e268 into 92e6cf99).

walle commented 12 years ago

Travis gets the following error:

Failures:
95
96  1) Gimli::Markup should handle textile-converted quotes properly
97     Failure/Error: markup.render.should == output
98     TypeError:
99       can't dup NilClass
100     # ./lib/gimli/markup.rb:46:in `dup'
101     # ./lib/gimli/markup.rb:46:in `render'
102     # ./spec/gimli/markup_spec.rb:24:in `block (2 levels) in <top (required)>'

Do you know why this can be?

I haven't tried this locally yet. I'll try to get time to do it today, but I have some more refactorings to complete before.

Thanks for contributing!

Regards, Fredrik