search

walle / gimli

Utility for converting markup files to pdf files
https://github.com/walle/gimli
MIT License
538 stars 44 forks source link

Recursion, Issue #4 #6

Closed nicknovitski closed 13 years ago

nicknovitski commented 13 years ago

I decided finishing this would be more fun than sleeping.

For the tests, I used the fixtures, and also the README file. I needed multiple files in different directories, and they seemed convenient. But the tests will break, for example, whenever any more fixtures are added. Does that make them too fragile?

walle commented 13 years ago

Thanks a lot for this fix! I rewrote the Path tests to use a subsection of the fixtures to do tests against. Now it will only fail if someone adds more markup files to the folders recursion in fixtures. I think it is a bit less brittle.

Nice touch renaming the File class, makes it a lot more clear what it does now.

This is in release 0.1.6!