Closed dmoklaf closed 8 years ago
Thank you! I'll merge this now. Github is currently experiencing problems, but I have your code as a remote locally and am looking it over/merging now. We will see when the changes are visible on Github, i.e. when they have resolved their connectivity issues.
On Mon, Apr 4, 2016 at 9:06 PM, Raphael Geronimi notifications@github.com wrote:
-Fixed a crash (panic) case where the files in arguments do not exist. Instead, a clean error is back-propagated now -Added an exclude optional argument to be able to skip temporary lines
(e.g., TODO)
You can view, comment on, or merge this pull request online at:
https://github.com/walle/lll/pull/1 Commit Summary
- Fixed a crash case and added an exclude optional parameter
File Changes
- M cmd/lll/main.go https://github.com/walle/lll/pull/1/files#diff-0 (9)
- M lll.go https://github.com/walle/lll/pull/1/files#diff-1 (12)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/walle/lll/pull/1
Ah I am sorry I didn't notice (and thus, updated) the _test files, consequently the travis CI fails. You can update them, or I can do it easily, let me know. Also, dont hesitate to rename the optional argument to follow your own conventions. Thanks
Thank you for your contribution!
I took your changes, and made some modifications to them.
I fixed the issue with the tests, and added some documentation to the README.
Thanks again!
-Fixed a crash (panic) case where the files in arguments do not exist. Instead, a clean error is back-propagated now -Added an exclude optional argument to be able to skip temporary lines (e.g., TODO)