search

walle / lll

Line length linter
MIT License
65 stars 9 forks source link

Add tabwidth argument to lll #2

Closed perpet closed 8 years ago

perpet commented 8 years ago

The tabwidth argument to lll makes it possible to configure how many characters a tab should be counted as. This is useful for reporting long lines which are indented.

The default value is 1, meaning legacy behavior is kept. By setting the tabwidth, it's easy to get warnings about other tab width settings, such as 4 and 8.

codecov-io commented 8 years ago

Current coverage is 72.72%

No coverage report found for master at 5a40569.

Powered by Codecov. Last updated by 5a40569...c43bf79

walle commented 8 years ago

Thank you for your contribution!

I personally do not see the point of the new option, as I see the point of using a tab character instead of spaces as indention is that it is just one character and your editor decides how to render it. I.e. the length of the line is not changed by how you decide to show tab characters in your editor.

But your patch does not change any existing behaviour and if you need this it won't hurt to have the option available. So I'm going to merge it now.

Thanks again for your contribution!

perpet commented 8 years ago

Thanks for merging!