search

walle / wiki

Command line tool to fetch summaries from MediaWiki wikis, like Wikipedia
MIT License
290 stars 14 forks source link

Go modules #17

Closed chenrui333 closed 5 years ago

chenrui333 commented 5 years ago

Renovate with go modules upgrade.

walle commented 5 years ago

Thank you for your PR! The new version 1.4.1 is now using go modules.

chenrui333 commented 5 years ago

so basically my PR got dropped? I am curious why you are doing that.

walle commented 5 years ago

It's not as much dropping your PR as reworking it a bit.

I merged another PR first, which was much smaller, which resulted in merge conflicts when trying to rebase your changes.

Also, I wanted to do some changes e.g. changing how golangci-lint was used, more linting rules, vendoring dependencies, replace a copied file with a dependency and some other small things. You can see the commit here https://github.com/walle/wiki/commit/33eb2f713879e72c11c1aecd82b3b47c1058ff65. So it was easier for me to do a new commit that did all of those changes.

Thanks again for your work! I would probably not have worked on this without it.