search

walle / wiki

Command line tool to fetch summaries from MediaWiki wikis, like Wikipedia
MIT License
290 stars 14 forks source link

color on windows #8

Closed mattn closed 9 years ago

mattn commented 9 years ago

walle commented 9 years ago

Thank you, I haven't thought about the windows support. I would rather not add a dependency to a library, since the tool doesn't have any other dependencies right now. Do you think it would be possible to add this functionality without adding a dependency? If not I guess it would be ok to add the dependency. But I think we will remove the line in the Makefile and add a paragraph in the README about the dependency instead. Go get will install the dependency anyway. What do you think about this?

mattn commented 9 years ago

If you think matter of confliction or vendoring or any another problems for third-party library, you should use godep and include libs in your repository. But your wiki command is possible to install with go get github.com/walle/wiki/cmd/wiki. This installation do go-get of go-colorble. So I don't think this is such a serious issue.

walle commented 9 years ago

Yes, you are right. I have merged this now.