search

wallento / wavedrompy

WaveDrom compatible python command line
Other
97 stars 23 forks source link

Use Conda for Test Environments #24

Open MutantPlatypus opened 5 years ago

MutantPlatypus commented 5 years ago

I just submitted pull request #23 to use tox for testing. I would like to build on that and use tox-conda. It would make it much easier to test across operating systems and allow new contributors to run tests locally with ease. It would also fully contain the node, npm, and git tools used in testing: It would not rely on the system installations. It also allows cairosvg to work with Windows. Tests would still be run by pytest, but conda would do all the dependency management for the test environment.

The test command would be similar to the pull request: just tox-conda instead of tox' . I would just add the nodejs and git packages to the conda dependencies.

The only downside I see is this would make miniconda a dependency for mutli-environment testing. venv and plain tox testing should still work without conda.

Edit: I got it working sooner than I expected. See PR #25.

wallento commented 4 years ago

Hi, thanks a lot. #25 has conflicts after I applied #23, can you please have a look?