walles
commented
1 year ago First of all, sorry for my slow response time.
I'm trying to optimize for ease of development.
Given that, the size benefit here doesn't help much, especially since I seldom update the screenshot. Being able to copy text from the SVG screenshot is nice, but I don't think many people would.
SVG downsides:
- Tool is unsupported ("As of June 2020 I do not have time to maintain
termtosvganymore and this repository is now read-only."): https://github.com/nbedos/termtosvg. This implies a risk of extra work if the tool would stop working for whatever reason. - Image not showing while reviewing: https://github.com/walles/moar/pull/117/files#diff-0a1c9f406e425c74a0aa8cc6b33a002fef7fbb15cd18476b4151591c94475871. This means there's a risk of extra work if somebody updates the screenshots.
Weighing the benefit of this change vs the (small, but still) cost of it, I won't be merging this.
This reduces the file size from 311 KiB to 8 KiB.
The screenshot was generated by: